Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use npm for all frontend dependencies #2144

Merged
merged 3 commits into from
Oct 18, 2023
Merged

Conversation

dpgaspar
Copy link
Owner

@dpgaspar dpgaspar commented Oct 18, 2023

Description

Use npm to manage all frontend dependencies.

Locally run:

npm install
npm run copy-files

bootstrap-datetimepicker as now moved to a maintained version

Note: this is changing some static locations

ADDITIONAL INFORMATION

  • Has associated issue:
  • Is CRUD MVC related.
  • Is Auth, RBAC security related.
  • Changes the security db schema.
  • Introduces new feature
  • Removes existing feature

@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

Merging #2144 (c26f557) into master (4db9a77) will decrease coverage by 33.51%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master    #2144       +/-   ##
===========================================
- Coverage   78.65%   45.15%   -33.51%     
===========================================
  Files          72       72               
  Lines        8695     8564      -131     
===========================================
- Hits         6839     3867     -2972     
- Misses       1856     4697     +2841     
Flag Coverage Δ
python 45.15% <ø> (-33.51%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
flask_appbuilder/fieldwidgets.py 50.00% <ø> (-11.02%) ⬇️

... and 56 files with indirect coverage changes

@dpgaspar dpgaspar merged commit 3cfe13f into master Oct 18, 2023
11 of 12 checks passed
@dpgaspar dpgaspar deleted the feat/bootstrap5 branch October 18, 2023 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant